Test RPC server external context cancellation #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dzmitry Mikhalapau <[email protected]>
|
@lthibault Hi! As promised, here are some simple tests for #595 |
Signed-off-by: Dzmitry Mikhalapau <[email protected]>
lthibault
requested changes
Jan 11, 2025
Signed-off-by: Dzmitry Mikhalapau <[email protected]>
|
@lthibault hm, seems like some tests are flaking. I can't rerun pipeline since I don't have enough permissions, but on my machine everything looks good: $ for i in `seq 50`; do ./rpc.test; done
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
PASS
[15:33:13] [cost 128.444s] for i in `seq 50`; do ./rpc.test; done |
|
Some of these tests occasionally flake out. I'll kick it off again. I don't consider it a blocker, given they're passing locally (just checked on my end as well). |
lthibault
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.